ropensci / taxize

A taxonomic toolbelt for R
https://docs.ropensci.org/taxize
Other
270 stars 61 forks source link

Improve rank indexing function (#873) #874

Closed trvinh closed 3 years ago

trvinh commented 3 years ago

Description

Modified rank indexing function to make it works with species contains many undefined ranks (norank).

Related Issue

Fix #873

Example

trvinh commented 3 years ago

@sckott can you review this PR please? The tests (for class2tree) were passed when I ran it locally. But I don't know how to make it here available without changing the files in fixtures folder. Btw, beside of running the R tests, I did actually ran the class2tree function for many random sets of species, so it should be good now :P

sckott commented 3 years ago

Sorry for the delay, looking now

sckott commented 3 years ago

LGTM