search

ropensci / tinkr

Convert (R)Markdown files to XML, edit them, write them back as (R)Markdown
https://docs.ropensci.org/tinkr
GNU General Public License v3.0
57 stars 3 forks source link

If no yaml, avoid prepending with gratuitous `\n` #93

Closed jennybc closed 1 year ago

jennybc commented 1 year ago

This PR adapts tinkr for forward compatibility with glue. I will release glue no sooner than 2 weeks from now, so on March 31 (or likely a bit later).

In the next version of glue, glue::glue_collapse() will never return character() but instead will return "" for empty inputs. For more detail see https://github.com/tidyverse/glue/pull/295.

In my hands, this PR makes tinkr work as intended with released glue and dev glue.

zkamvar commented 1 year ago

Thank you! I will admit, when I saw that you had forked the repo, I was kind of excited because "OMG JB noticed!"

I've tested this locally with the dev version of glue and can confirm that it works. I'm going to merge.

Would you like to be added to the DESCRIPTION as a contributor?

I will definitely get this submitted to CRAN if not today then next week by Wednesday.

jennybc commented 1 year ago

Would you like to be added to the DESCRIPTION as a contributor?

No thanks, this is just me fixing a small thing we're going to break 😅

I will definitely get this submitted to CRAN if not today then next week by Wednesday.

Thanks!