search

ropensci / tokenizers

Fast, Consistent Tokenization of Natural Language Text
https://docs.ropensci.org/tokenizers
Other
184 stars 25 forks source link

Clarification of argument documentation for x #71

Closed EmilHvitfeldt closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #71 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #71   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files          12       12           
  Lines         426      426           
=======================================
  Hits          418      418           
  Misses          8        8
Impacted Files Coverage Δ
R/basic-tokenizers.R 100% <ø> (ø) :arrow_up:
R/stem-tokenizers.R 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a4b824f...99a019e. Read the comment docs.

lmullen commented 5 years ago

@EmilHvitfeldt Thanks for the PR. I'm willing to merge this in. But could you please make comparable changes if necessary to the documentation for x in the other tokenizers and add them to this PR?

EmilHvitfeldt commented 5 years ago

I think I found all the needed changes.