ropensci / vcr

Record and replay HTTP requests
https://docs.ropensci.org/vcr
Other
77 stars 12 forks source link

write to disk: record paths relative to the test suite dir? #135

Closed sckott closed 4 years ago

sckott commented 4 years ago

realized right now with writing to disk tests, we record the absolute file path - which is fine as long as the tests are run on the same machine/server. but if the same tests are run on a different machine, they will likely fail. no bueno

sckott commented 4 years ago

I think we need to enforce when the user sets write_disk_path in vcr_configure() that the path is relative to the fixture/cassette path.

sckott commented 4 years ago

makes sense to do the check within vcr_configure() probably so that we maybe don't need to do those path checks within the rest of the package