ropensci / vcr

Record and replay HTTP requests
https://docs.ropensci.org/vcr
Other
77 stars 12 forks source link

README and vignette tweaks #199

Closed maelle closed 4 years ago

maelle commented 4 years ago
codecov-io commented 4 years ago

Codecov Report

Merging #199 (2ceed20) into master (27db7bf) will increase coverage by 0.62%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #199      +/-   ##
==========================================
+ Coverage   79.98%   80.61%   +0.62%     
==========================================
  Files          39       40       +1     
  Lines        1574     1733     +159     
==========================================
+ Hits         1259     1397     +138     
- Misses        315      336      +21     
Impacted Files Coverage Δ
R/skip-vcr-off.R 50.00% <0.00%> (ø)
R/insert_cassette.R 93.54% <0.00%> (+0.44%) :arrow_up:
R/cassette_class.R 85.98% <0.00%> (+1.01%) :arrow_up:
R/response_class.R 77.77% <0.00%> (+2.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 27db7bf...2ceed20. Read the comment docs.

maelle commented 4 years ago

I made the changes but I would like to keep the YAML in the README.Rmd because it allows me to use the RStudio knit button to knit the README. :smile_cat: Only if it doesn't break your Make workflow, of course.

sckott commented 4 years ago

we can leave the readme yaml. knitr doesnt know to pull that yaml out of the .md i guess, probably ok though