Date parse error when on devtools::check

[peterdesmet]

When doing a devtools::check(), I get:

* checking examples ... ERROR
Running examples in ‘wateRinfo-Ex.R’ failed
The error most likely occurred in:

> base::assign(".ptime", proc.time(), pos = "CheckExEnv")
> ### Name: get_timeseries_tsid
> ### Title: Download timeseries data from waterinfo.be
> ### Aliases: get_timeseries_tsid
> 
> ### ** Examples
> 
> get_timeseries_tsid("35055042", from = "2017-01-01", to = "2017-01-02")
Error in check_date_format(from) : 
  The date string can not be properly parsed in any of the
             following formats: ymd_hms, ymd, ym, y)
Calls: get_timeseries_tsid -> parse_period -> check_date_format
Execution halted

Line causing the error:

https://github.com/inbo/wateRinfo/blob/199e426b18b4957584cd54d935607b7d1dff25f2/R/get_timeseries.R#L35

Function called:

https://github.com/inbo/wateRinfo/blob/a31a5c231f7ee59056ee3183103553cb5ee83142/R/parse_period.R#L49-L60

I have tried to look into this, but I am stuck. 😄

[peterdesmet]

Debugging so far:

1. On branch master
2. Create project in wateRinfo root
3. Do Install and Restart (or use library(wateRinfo)
4. In console do: get_timeseries_tsid("35055042", from="2017-01-01", to="2017-01-02")

 Error in check_date_format(from) : 
  The date string can not be properly parsed in any of the
             following formats: ymd_hms, ymd, ym, y) 

5. Do get_timeseries_tsid("5156042", period = "P3D")
6. Works
7. Do get_timeseries_tsid("35055042", from="2017-01-01", to="2017-01-02") again:
8. Works

[stijnvanhoey]

When I try to reproduce step 1 -> 4, I get the data.frame as expected...

[stijnvanhoey]

@peterdesmet still an issue?

[peterdesmet]

I still get the same error:

1. Error: Impossible date/period input combinations (@test-period_formatting.R#62) 

Error: testthat unit tests failed

Maybe there is an issue with my system date settings?

[stijnvanhoey]

Seems a failure of a unit test now, whereas previously, it was an example in the roxygen documentation, get_timeseries_tsid("35055042", from = "2017-01-01", to = "2017-01-02").

The test of line 62 on the test-period_formatting.R file is:

parse_period(from = "2012-11-01", to = "2013-12-01")

could you recheck and provide some additional info by providing the output of sessionInfo()?

[stijnvanhoey]

@peterdesmet can you have a check if this is still relevant?

[peterdesmet]

Package builds fine, so I'm not getting this error anymore. Closing issue.