search

ros-geographic-info / geographic_info

ROS packages for geographic information
http://ros.org/wiki/geographic_info
60 stars 61 forks source link

Force UTM Zone to gracefully handle UTM boundaries #20

Open valschmidt opened 6 years ago

valschmidt commented 6 years ago

This pull requests implements a new version of the fromLatLong() method that allows one to optionally specify the UTM zone explicitly. This functionality allows one to establish a single UTM zone for operations and prevents the need to change an entire reference frame on the fly as the robot passes across zone boundaries.

jack-oquin commented 6 years ago

Seems like a good idea. Are there any unit tests for the new feature?

valschmidt commented 6 years ago

There is not. Are there unit tests for the rest of the geodesy package that they could be based on?

Oh, BTW, I have noticed that I have a typo in this pull request. (I’m not sure how I did that.)

-Val

UPDATE: This is fixed.

On Aug 13, 2017, at 12:18 PM, jack-oquin notifications@github.com wrote:

Seems like a good idea. Are there any unit tests for the new feature?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ros-geographic-info/geographic_info/pull/20#issuecomment-322051359, or mute the thread https://github.com/notifications/unsubscribe-auth/ACT018r20g0j1PMl4eOxnOfcE_hRsx5vks5sXyHYgaJpZM4Ot6x6.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/ros-geographic-info/geographic_info","title":"ros-geographic-info/geographic_info","subtitle":"GitHub repository","main_image_url":"https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://cloud.githubusercontent.com/assets/143418/15842166/7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in GitHub","url":"https://github.com/ros-geographic-info/geographic_info"}},"updates":{"snippets":[{"icon":"PERSON","message":"@jack-oquin in #20: Seems like a good idea. Are there any unit tests for the new feature?"}],"action":{"name":"View Pull Request","url":"https://github.com/ros-geographic-info/geographic_info/pull/20#issuecomment-322051359"}}}

Val Schmidt Center for Coastal and Ocean Mapping / Joint Hydrographic Center University of New Hampshire Chase Ocean Engineering Lab 24 Colovos Road Durham, NH 03824 e: vschmidt [AT] ccom.unh.edu m: 614.286.3726