search

ros-industrial / industrial_ci

Easy continuous integration repository for ROS repositories
Apache License 2.0
249 stars 129 forks source link

catkin_tools_devel.sh: drop --install flag #757

Closed rhaschke closed 3 years ago

rhaschke commented 3 years ago

I need to come back to https://github.com/ros-industrial/industrial_ci/pull/707/files#r673922264. Unfortunately, using a linked devel-space layout is not compatible with the --install flag: https://github.com/catkin/catkin_tools/issues/674#issuecomment-879008090.

Sourcing devel/setup.bash doesn't yield the correct ROS_PACKAGE_PATH (not including the sourced workspace), such that find_package(catkin ...) yields wrong results. Dropping the --install flag, everything works as expected.

mathias-luedtke commented 3 years ago

Unfortunately, using a linked devel-space layout is not compatible with the --install flag

So wouldn't it be better to use a merged space instead?

rhaschke commented 3 years ago

Not sure a merged devel-space solves the issue. However, our goal in MoveIt is to test a common use case, namely the (default) linked devel-space.

mathias-luedtke commented 3 years ago

However, our goal in MoveIt is to test a common use case, namely the (default) linked devel-space.

Makes sense. Most likely you are the only user of this feature anyway ;)

rhaschke commented 3 years ago

Thanks.