search

ros-industrial / kuka_experimental

Experimental packages for KUKA manipulators within ROS-Industrial (http://wiki.ros.org/kuka_experimental)
Apache License 2.0
264 stars 212 forks source link

Enable CI for ROS Noetic #202

Closed simonschmeisser closed 2 years ago

gavanderhoorn commented 2 years ago

Not sure that's the reason for the failure:

2021-09-28T09:10:04.4677895Z Starting  >>> kuka_kr210_support                  
2021-09-28T09:10:04.4678695Z 
2021-09-28T09:10:04.4680470Z Warnings   << kuka_kr210_support:make /root/target_ws/logs/kuka_kr210_support/build.make.001.log
2021-09-28T09:10:04.4682258Z name 'deg' is not defined 
2021-09-28T09:10:04.4683193Z when evaluating expression '-185*deg'
2021-09-28T09:10:04.4684372Z when instantiating macro: kuka_kr210l150 (/root/target_ws/src/kuka_experimental/kuka_kr210_support/urdf/kr210l150_macro.xacro)
2021-09-28T09:10:04.4685518Z in file: /root/target_ws/src/kuka_experimental/kuka_kr210_support/urdf/kr210l150.xacro
2021-09-28T09:10:04.4686275Z FAILURE:
2021-09-28T09:10:04.4687024Z [/root/target_ws/src/kuka_experimental/kuka_kr210_support/test/roslaunch_test.xml]:
2021-09-28T09:10:04.4688245Z    while processing /root/target_ws/src/kuka_experimental/kuka_kr210_support/launch/load_kr210l150.launch:
2021-09-28T09:10:04.4692249Z Invalid <param> tag: Cannot load command parameter [robot_description]: command [['/opt/ros/noetic/lib/xacro/xacro', '/root/target_ws/src/kuka_experimental/kuka_kr210_support/urdf/kr210l150.xacro']] returned with code [2]. 
2021-09-28T09:10:04.4693527Z 
2021-09-28T09:10:04.4694501Z Param xml is <param name="robot_description" command="$(find xacro)/xacro '$(find kuka_kr210_support)/urdf/kr210l150.xacro'"/>
2021-09-28T09:10:04.4696077Z wrote test file to [/root/target_ws/build/kuka_kr210_support/test_results/kuka_kr210_support/roslaunch-check_test_roslaunch_test.xml.xml]

Edit: hm, interesting. Why would --inorder change the behaviour here.

simonschmeisser commented 2 years ago

No, the reason for the failure is that apparently scoping of parameters changed in noetic so the deg defined outside the macro property cannot be used inside the macro. But that was fixed by merging #195 and rebasing

simonschmeisser commented 2 years ago

Re edit: it doesn't, rebasing to a version that uses radians() did