search

ros-industrial / staubli_experimental

Experimental packages for Staubli manipulators within ROS-Industrial (http://wiki.ros.org/staubli_experimental)
Apache License 2.0
26 stars 27 forks source link

val3_driver: Updated repo URL within README #17

Closed MuriloMartins closed 8 years ago

MuriloMartins commented 8 years ago

This PR addresses issue #13.

gavanderhoorn commented 8 years ago

Btw: the readme also directs users to:

[..] copy the contents of val3_driver folder [..]

But that folder doesn't exist. The same val3_driver name is used further on in the document as well.

Should that be val3? Or would you want them to copy the ros_libs and ros_server directories separately?

MuriloMartins commented 8 years ago

Oh, I seem to remember to have named that folder as val3_driver. I didn't realise that it had been renamed...

gavanderhoorn commented 8 years ago

@MuriloMartins wrote:

Oh, I seem to remember to have named that folder as val3_driver. I didn't realise that it had been renamed...

ah, right. Yes, I did that (when cleaning up the commits in #10) to get staubli_val3_driver more in-line with the other driver packages (ie: fanuc_driver/karel, abb_driver/rapid, etc). The directory already lives in a package with driver in it, so seems redundant to suffix it again.

MuriloMartins commented 8 years ago

Just a sec, I'm working on it! ;-)

gavanderhoorn commented 8 years ago

https://github.com/ros-industrial/staubli_experimental/pull/10#issuecomment-231539601 explains what happened :).

MuriloMartins commented 8 years ago

Yes I remember now! Thanks!

I've just updated the readme with the correct branch (indigo-devel) and folder (val3) names.

gavanderhoorn commented 8 years ago

Thanks for the updates.

I'm going to squash-merge this.