ros-infrastructure / ros_buildfarm

ROS buildfarm based on Docker
Apache License 2.0
77 stars 95 forks source link

Additional fixes for RPM triggers for upload jobs #1053

Closed cottsay closed 1 month ago

cottsay commented 1 month ago

It turns out that the format of the sync-to-testing job names is even more complicated than what was constructed here, so we were still adding incorrect job names there. The previous update to this function didn't regress that, but it also didn't fix it.

It turns out that there are functions to just do the formatting for us, so we should just use that.

Follow-up to #1052

Here's the diff, note that rhel_ now appears in the RHEL job names.

Skipped 'upload_main' because the config is the same (dry run)
Updating job 'upload_testing' (dry run)
    <<<
    --- remote config
    +++ new config
    @@ -26 +26 @@
    -      <upstreamProjects>Hrel_sync-packages-to-testing_8_x86_64,Hrel_sync-packages-to-testing_jammy_amd64,Hrel_sync-packages-to-testing_jammy_arm64,Irel_sync-packages-to-testing_9_x86_64,Irel_sync-packages-to-testing_jammy_amd64,Irel_sync-packages-to-testing_jammy_arm64,Jrel_sync-packages-to-testing_9_x86_64,Jrel_sync-packages-to-testing_noble_amd64,Jrel_sync-packages-to-testing_noble_arm64,Rrel_sync-packages-to-testing_9_x86_64,Rrel_sync-packages-to-testing_noble_amd64,Rrel_sync-packages-to-testing_noble_arm64,import_upstream,import_upstream_rpm</upstreamProjects>
    +      <upstreamProjects>Hrel_sync-packages-to-testing_jammy_amd64,Hrel_sync-packages-to-testing_jammy_arm64,Hrel_sync-packages-to-testing_rhel_8_x86_64,Irel_sync-packages-to-testing_jammy_amd64,Irel_sync-packages-to-testing_jammy_arm64,Irel_sync-packages-to-testing_rhel_9_x86_64,Jrel_sync-packages-to-testing_noble_amd64,Jrel_sync-packages-to-testing_noble_arm64,Jrel_sync-packages-to-testing_rhel_9_x86_64,Rrel_sync-packages-to-testing_noble_amd64,Rrel_sync-packages-to-testing_noble_arm64,Rrel_sync-packages-to-testing_rhel_9_x86_64,import_upstream,import_upstream_rpm</upstreamProjects>
    >>>
cottsay commented 1 month ago

This has been deployed.