search

ros-infrastructure / superflore

An extended platform release manager for Robot Operating System
Apache License 2.0
52 stars 33 forks source link

Use "git describe" to append a local version label #262

Closed shr-project closed 4 years ago

shr-project commented 4 years ago

and small fix for superflore-datetime.inc.

allenh1 commented 4 years ago

@tfoote please review this one -- you know quite a bit more than I do about this.

shr-project commented 4 years ago

@herb-kuta-lge FYI

shr-project commented 4 years ago

@herb-kuta-lge requested to split this pull request into smaller ones with separate issue tickets and to leave this original one for setup.py change he plans to update with different implementation based on @tfoote's feedback. I've created: https://github.com/ros-infrastructure/superflore/pull/265 https://github.com/ros-infrastructure/superflore/pull/266 https://github.com/ros-infrastructure/superflore/pull/267 https://github.com/ros-infrastructure/superflore/pull/268 https://github.com/ros-infrastructure/superflore/pull/269 https://github.com/ros-infrastructure/superflore/pull/270 to cover the other changes which were here yesterday.

herb-kuta-lge commented 4 years ago

@tfoote < Please review the latest implementation. I believe it addresses all of your concerns.