search

ros-infrastructure / superflore

An extended platform release manager for Robot Operating System
Apache License 2.0
52 stars 33 forks source link

Evaluate package conditions when generating ebuilds #294

Open nuclearsandwich opened 2 years ago

nuclearsandwich commented 2 years ago

ebuild generation was not utilizing package conditions. Packages with multiple build types were causing hard failures during ebuild generation but it's possible that invalid ebuilds were being generated for other packages as well due to the lack of dependency conditions.

Fixes #289.

nuclearsandwich commented 2 years ago

It looks like we need more updates to validate it well. CI's now running on what looks to be EOL platforms.

Yeah, I built this based on the similar support for the oe platform, which doesn't rely on docker for any part of its process. I would be inclined to merge this as-is since bringing CI back online for the Gentoo side is going to be a large investment. I think the next PR I would make would update CI platforms and disable Gentoo tests entirely in order to allow CI to continue for the OpenEmbedded/Yocto people still using the tool regularly.

nuclearsandwich commented 2 years ago

I would be inclined to merge this as-is since bringing CI back online for the Gentoo side is going to be a large investment.

I'll hold onto this until the end of the week in case I am struck with any further inspiration here. Then I'll merge unless there's an objection.