ros-perception / depthimage_to_laserscan

Converts a depth image to a laser scan for use with navigation and localization.
243 stars 163 forks source link

[Windows][ros2] Export interfaces for Shared Lib on Windows #44

Closed seanyen closed 4 years ago

seanyen commented 4 years ago

On Windows, for a shared library, the interfaces must be explicitly decorated by proper dllimport and dllexport usage. Otherwise, no imported library (.lib) will be generated for the downstream projects to consume at link time.

This pull request is to add the interface export in a portable way provided by CMake (instead of directly using MSVC specific dllimport and dllexport).

This is a rework for #39

seanyen commented 4 years ago

cc @clalancette