Add a sensor_msgs dependency to test_scan_filter_chain

ros-perception / laser_filters

Assorted filters designed to operate on 2D planar laser scanners, which use the sensor_msgs/LaserScan type.

BSD 3-Clause "New" or "Revised" License

175 stars 206 forks source link

Add a sensor_msgs dependency to test_scan_filter_chain #159

Closed clalancette closed 2 years ago

clalancette commented 2 years ago

Signed-off-by: Chris Lalancette clalancette@openrobotics.org

This should fix build errors like in https://build.ros2.org/view/Rbin_uJ64/job/Rbin_uJ64__laser_filters__ubuntu_jammy_amd64__binary/19/console

mjcarroll commented 2 years ago

Rolling CI has some python3.9 related messages eg:

gmake[2]: *** No rule to make target '/usr/lib/x86_64-linux-gnu/libpython3.9.so', needed by 'liblaser_scan_filters.so'.  Stop.

Which seems unexpected.

clalancette commented 2 years ago

Which seems unexpected.

Hm, yeah, that is unexpected. Maybe the docker images haven't been updated yet? I'm not sure.

jonbinney commented 2 years ago

Yes there is some bizarro python error message on rolling. That seems to have nothing to do with this PR though. I'm closing my eyes and hoping that error resolves itself. This PR looks good; merging!

clalancette commented 2 years ago

@jonbinney Thanks for merging! When you get a chance, can you do a new release into Rolling? That should finally resolve the build error.

jonbinney commented 2 years ago

Released: https://github.com/ros/rosdistro/pull/32731