search

ros-ukraine / leobot

LeoBot telepresence robot
MIT License
21 stars 4 forks source link

Rotational camera in simulation #131

Closed MaxZhaloba closed 5 years ago

MaxZhaloba commented 6 years ago

Closes #130

MaxZhaloba commented 6 years ago

@AndriyPt, I've converted the joint for the head link to continuous type. It makes it possible to rotate the camera in Rviz. Please let me know if any other adjustments are necessary.

AndriyPt commented 6 years ago

@MaxZhaloba in real robot this link is fixed. Please connect "eyes" with extra bar and make it rotational on top of Г part of the robot.

ldemk commented 5 years ago

@MaxZhaloba Did You make changes to the gazebo file?

MaxZhaloba commented 5 years ago

I'm working on it right now. Implementing the changes requested by Andriy. He told me that it's ok to leave the fish eye cameras for now but attach them to rotating bar.

MaxZhaloba commented 5 years ago

I've fixed the indentation and deleted the xml declaration in all xacro files. No significant changes, only code formatting.

MaxZhaloba commented 5 years ago

@AndriyPt, Please review my updated implementation.

AndriyPt commented 5 years ago

@MaxZhaloba it is hard to see you changes. Please revert indentation fixes and post them as separate pull request. Please do one task in one pull request. It is harder to review code such pull requests.

MaxZhaloba commented 5 years ago

Ok, will do.

MaxZhaloba commented 5 years ago

@AndriyPt, done.