search

ros-visualization / rqt_bag

http://wiki.ros.org/rqt_bag
31 stars 55 forks source link

Adapted to rosbag2_py #156

Closed ahcorde closed 6 months ago

ahcorde commented 6 months ago

This PR fix the new changes included in rosbag2_py.

Still a draft.

Requires https://github.com/ros2/rosbag2/pull/1642

TODO

ahcorde commented 6 months ago

TODO

When I read a bag file and try to click on the checkboxes, I'm only able to publish the second element of the list if there are more than 1 element.

clalancette commented 6 months ago

I just updated the license for the code we are adapting from PIL.

Besides that, I did a quick test with this. I ran a demo (ros2 run demo_nodes_cpp talker), recorded a bag (ros2 bag record /chatter), and then opened the bag with rqt_bag. As soon as I opened the bag, the CPU usage of the rqt process spiked to 100% and stayed there. I am going to poke at that next.

ahcorde commented 6 months ago
clalancette commented 6 months ago

@mergifyio backport jazzy

mergify[bot] commented 6 months ago

backport jazzy

✅ Backports have been created

* [#165 Adapted to rosbag2_py (backport #156)](https://github.com/ros-visualization/rqt_bag/pull/165) has been created for branch `jazzy`