ros-visualization / rqt_reconfigure

http://wiki.ros.org/rqt_reconfigure
Other
23 stars 50 forks source link

Convert synchronous/blocking calls to parameter services to async #96

Closed mjeronimo closed 3 years ago

mjeronimo commented 4 years ago

Rqt_reconfigure should be updated to use async calls to the parameter service(s). First, it is (incorrectly) assuming that every node supports the parameter services. However, if one creates a parameter client for a node which doesn't provide the corresponding services and then invoke it, the synchronous call will hang. Next, even if a node does support the parameter services, the node may not be spinning (for example, a node created just to make a service call). In this latter case, using a synchronous call to a parameter service will also hang the calling app.