use boost::shared_ptr instead of raw pointers for more condense code and... - Githubissues

ros-visualization / visualization_tutorials

Tutorials related to using and extending RViz and interactive_markers.

263 stars 263 forks source link

use boost::shared_ptr instead of raw pointers for more condense code and... #1

Closed vrabaud closed 11 years ago

vrabaud commented 11 years ago

... to fix a memory leak

dgossow commented 11 years ago

@hershwg What's with this? Merge? Seems like an improvement. Will test later.

hershwg commented 11 years ago

Right, I got distracted. The change looks good at this point, I just needed to test it. Which I still haven't done.

dgossow commented 11 years ago

I tried to test this today, but the tutorial just crashes rviz on my machine.

vrabaud commented 11 years ago

damn, it was running for me on Precise 64.

dgossow commented 11 years ago

Might as well be a bug in rviz or classloader. Will look into this later this week.

dgossow commented 11 years ago

ok, so the segfault probably came from somewhere else. will re-evaluate next week.

dgossow commented 11 years ago

Tested and works fine. Thanks Vincent!