search

ros / urdf_tutorial

234 stars 258 forks source link

Jade Release #13

Closed wjwwood closed 9 years ago

wjwwood commented 9 years ago

This is included in desktop-full: http://wiki.ros.org/jade/Planning/Maintenance

@DLu do you have time to do this release?

DLu commented 9 years ago

I just started working on it today. I'm waiting to hear back from @isucan about his maintainer status.

isucan commented 9 years ago

David, i am unable to do anything for this until next week. If you'd like to become the maintainer for this, that would be very helpful. Doing this release alone would also be very helpful. Thanks! On Apr 23, 2015 23:06, "David Lu!!" notifications@github.com wrote:

I just started working on it today. I'm waiting to hear back from @isucan https://github.com/isucan about his maintainer status.

— Reply to this email directly or view it on GitHub https://github.com/ros/urdf_tutorial/issues/13#issuecomment-95718994.

DLu commented 9 years ago

Hrm. So urdf_tutorial has a runtime dependency on pr2_description because it uses meshes from the pr2 gripper

Should I A) Save local versions of the meshes B) Wait for a jade release of pr2_description? C) Remove the run_depends but not the code. D) Panic. E) Something else ?

wjwwood commented 9 years ago

It would be nice not to have to depend on pr2_description, but it seems like pr2_common could be released if convex_decomposition (https://github.com/ros/convex_decomposition/issues/2) and ivcon (https://github.com/ros/ivcon/issues/2) get released. If it can get done in the short term, I'd say B).

DLu commented 9 years ago

Not sure if there's going to be any movement on the jade release of pr2_common.

If I went with A, would the best method be a literal copy and paste of the files, or something else, do you think?

wjwwood commented 9 years ago

Copying it would be fine. Though, I think part of the tutorial is to show that you can use resources from outside of the package you are in. Given the list of not so good options, I guess we go with A.

wjwwood commented 9 years ago

Hold on that, @TheDash gave me permission to get pr2_description released. I'll do it now.

wjwwood commented 9 years ago

Ok, pr2_common is in flight: https://github.com/ros/rosdistro/pull/8241

Once that's merged then you should be clear to release this @DLu, thanks for your help!

wjwwood commented 9 years ago

@DLu I'd like to get this out today, do you have time, or should I do it?

DLu commented 9 years ago

https://github.com/ros/rosdistro/pull/8257

wjwwood commented 9 years ago

Thanks!