Mention that ready_fn in generate_test_description is deprecated

ros2 / launch

Tools for launching multiple processes and for writing tests involving multiple processes.

Apache License 2.0

126 stars 141 forks source link

Mention that ready_fn in generate_test_description is deprecated #623

Closed Bi0T1N closed 2 years ago

Bi0T1N commented 2 years ago

Foxy already shows: Warning: Passing ready_fn as an argument to generate_test_description will be removed in a future release. Include a launch_testing.actions.ReadyToTest action in the LaunchDescription instead.

see https://github.com/ros2/launch/pull/346

-> re-targeted version of https://github.com/ros2/launch/pull/580

clalancette commented 2 years ago

Since this is just a change to the README, I'm going to just go with the results from the Gpr job. I'll also backport this to Foxy.

clalancette commented 2 years ago

@Mergifyio backport foxy

mergify[bot] commented 2 years ago

backport foxy

✅ Backports have been created

* [#624 Mention that ready_fn in generate_test_description is deprecated (backport #623)](https://github.com/ros2/launch/pull/624) has been created for branch `foxy`