ros2 / launch

Tools for launching multiple processes and for writing tests involving multiple processes.
Apache License 2.0
124 stars 139 forks source link

Duplicate Launch Arguments fail quietly #677

Open owen7900 opened 1 year ago

owen7900 commented 1 year ago

Bug report

Including 2 python launch descriptions with the same launch arguments declared with different descriptions causes some nodes not to launch and does not specify the cause of failure.

I think the desired functionality would be warning the user and appending the two descriptions together. The latter behaviour would allow for maximum interoperability so that all ROS developers don't need to have the exact same descriptions for common arguments (such as use_sim_time ).

Required Info:

Steps to reproduce issue

Create 2 python launch descriptions with the same launch argument declared with different descriptions. Add some other actions to each description and observe which actions get executed.

Expected behavior

I think the desired functionality would be warning the user and appending the two descriptions together. The latter behaviour would allow for maximum interoperability so that all ROS developers don't need to have the exact same descriptions for common arguments (such as use_sim_time ).

Actual behavior

Some actions do not execute or do not execute correctly, fail quietly.