search

ros2 / rclcpp

rclcpp (ROS Client Library for C++)
Apache License 2.0
563 stars 427 forks source link

Correct the incorrect comments in generic_client.hpp #2662

Closed Barry-Xu-2018 closed 3 weeks ago

Barry-Xu-2018 commented 3 weeks ago

This is a minor fix.

Since the current rmw does not provide an interface to obtain serialized request and response data, both generic_client and generic_service are currently handling deserialized untyped data.

In the code comments, it was mistakenly written as serialized data.

ahcorde commented 3 weeks ago

Pulls: ros2/rclcpp#2662 Gist: https://gist.githubusercontent.com/ahcorde/b478acc0a16df1d9e7ffe5f2cc2d29c7/raw/0b7c7c9a92583cbd5bb511ecd21d5bfddd1f146e/ros2.repos BUILD args: --packages-up-to rclcpp --packages-above-and-dependencies rclcpp TEST args: --packages-select rclcpp --packages-above rclcpp ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14782