search

ros2 / rclcpp

rclcpp (ROS Client Library for C++)
Apache License 2.0
563 stars 427 forks source link

accept custom allocator for LoanedMessage. #2672

Closed fujitatomoya closed 1 week ago

fujitatomoya commented 2 weeks ago

closes https://github.com/ros2/rclcpp/issues/2671

fujitatomoya commented 2 weeks ago

Pulls: ros2/rclcpp#2672 Gist: https://gist.githubusercontent.com/fujitatomoya/c94c33d5d9b178b7fdb3a880191237b7/raw/ae815ef620a2b5f805d36af338047dadb02555dd/ros2.repos BUILD args: --packages-above-and-dependencies rclcpp TEST args: --packages-above rclcpp ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14815

fujitatomoya commented 1 week ago

Also, would it be possible to back-port this change to jazzy and iron?

I think we can, this can be more flexible to take the argument for message allocator, besides no tests are broken with this change. but technically this breaks ABI compatibility, that is what i am not fully sure.

fujitatomoya commented 1 week ago

Pulls: ros2/rclcpp#2672 Gist: https://gist.githubusercontent.com/fujitatomoya/9fe827a2c4aba0b645be3e8916f1b248/raw/ae815ef620a2b5f805d36af338047dadb02555dd/ros2.repos BUILD args: --packages-above-and-dependencies rclcpp TEST args: --packages-above rclcpp ROS Distro: rolling Job: ci_launcher ci_launcher ran: https://ci.ros2.org/job/ci_launcher/14835