search

ros2 / rmw_fastrtps

Implementation of the ROS Middleware (rmw) Interface using eProsima's Fast RTPS.
Apache License 2.0
147 stars 116 forks source link

Improve wide string (de)serialization in rwm_dynamic_fastrtps_cpp #740

Closed MiguelCompany closed 4 months ago

MiguelCompany commented 4 months ago

This PR:

  1. Moves private headers to src
  2. Changes (de)serialization of wide strings so they don't perform u16string <-> wstring conversions
  3. Fixes an off-by-one mistake in the calculation of the serialized size of wide strings
  4. Removes dependencies to rosidl_typesupport_fastrtps_c(pp), i.e. fixes #382
fujitatomoya commented 4 months ago

CI:

MiguelCompany commented 4 months ago

@fujitatomoya thanks for the review

I think you messed up something when launching the CI.

I would enable rmw_fastrtps_dynamic_cpp, as well as the RMWs for Cyclone and Connext, build up to test_communication and run the tests in that package to check interoperability has not been broken

fujitatomoya commented 4 months ago

@MiguelCompany sorry about that.

MiguelCompany commented 4 months ago

@fujitatomoya @clalancette Can this be merged?