search

rose-pine / tm-theme

Soho vibes for TextMate
4 stars 0 forks source link

Theme does not correspond to syntax highlight in text editors #1

Open drybalka opened 2 months ago

drybalka commented 2 months ago

Hey, I know it is a bit of nitpicking at this point, but it kinda bothers me that the highlight colors used by bat do not correspond to the ones used in helix, neovim, sublime, or other text editors. For example, in the sublime config the built-ins are colored with "love" color, whereas here the "iris" color is used. It would be more consistent if the highlighting were the same across all applications. Would you be interested in such a fix?

arrrgi commented 2 months ago

I think that would be a decision for @mvllow or @ThatOneCalculator to provide feedback on.

I would recommend providing some screenshots showing the differences and the proposed fix along with a PR and see what feedback you get.

mvllow commented 2 months ago

I would personally consider Neovim to be a great reference for the "source of truth" but also it's semi-intentional to be relaxed and flexible enough so that anyone willing to donate their time porting Rosé Pine can do so with their own rendition. That being said, any PR that unifies colour usage between ports is always appreciated :)

Perhaps it would make contributing easier for some if we did have more specific documentation for applying our palette, even if simply a suggestion