rose-pine / vscode

Soho vibes for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=mvllow.rose-pine
MIT License
460 stars 17 forks source link

add italic variants (attribute and function names) #17

Closed rcrooks closed 3 years ago

rcrooks commented 3 years ago

Hi @mvllow Love this theme and thought I'd offer these variants I made for my local copy - it's very modest: I just added italics to attribute and function names, as I find this makes code more readable for me. I initially just did it for the main theme, but thought I might as well do it for the dawn and moon variants also.

I also modified the package.json to include these italic variants.

Best, Robert

mvllow commented 3 years ago

Thanks for adding these!

We are currently using pinecone to generate the different variants but the italics shouldn't conflict. It may be smart to remove all italics from the non-italic variants but that's another issue I will look at 🥰

I want to test locally and then will merge asap!

rcrooks commented 3 years ago

Thanks. Whatever you decide to do is ok with me. Love your theme anyway.

mvllow commented 3 years ago

I think this change is subtle (and welcome) enough to be added into the main variants, rather than italic variants. Merged in #18, thanks again!

rcrooks commented 3 years ago

Even better -- thanks!