search

rosenpin / screenshot-sharer

A quick & easy way to share screenshots on Android
https://f-droid.org/en/packages/io.rosenpin.screenshotsharer/
GNU General Public License v3.0
17 stars 7 forks source link

F-Droid issues #14

Open licaon-kter opened 8 months ago

licaon-kter commented 8 months ago

https://github.com/rosenpin/screenshot-sharer/releases/tag/3.5

rosenpin commented 8 months ago

the app is now published on F-droid and Google Play, so there's no reason to publish the apk here anymore

licaon-kter commented 8 months ago

Did you read https://f-droid.org/docs/Inclusion_How-To/#reproducible-builds already? :smile:

licaon-kter commented 8 months ago

F-Droid needs to verify if the app is build reproducible... how can it verify it there's no APK to verify against, from you, the developer?

rosenpin commented 8 months ago

you're right, I figured f-droid just builds the APKs on their own.
I'll build the apk and publish it then

licaon-kter commented 8 months ago

Thanks

rosenpin commented 8 months ago

solved with 3.6

licaon-kter commented 8 months ago

Thanks https://gitlab.com/fdroid/fdroiddata/-/commit/2517550ea0794d97bb51a766690ab28f834840c7

licaon-kter commented 8 months ago

And 3.6 is not repro.... https://gitlab.com/fdroid/fdroiddata/-/jobs/5907642684#L359

/LE: fyi https://gitlab.com/fdroid/fdroiddata/-/commit/65b81f740ebbd671d7d3cfcb9cc948d1045da545

licaon-kter commented 8 months ago

diff log: scrs40.log

rosenpin commented 8 months ago

Not sure what that's about.
Hopefully it works fine in the next release.
For now you can grab the apk from the release page, Google Play or compile it yourself

licaon-kter commented 8 months ago

https://github.com/rosenpin/screenshot-sharer/blob/3.6/app/build.gradle#L40

reading https://gitlab.com/fdroid/fdroiddata/-/issues/3138 I guess bumping it to 1.5.7 might fix it

licaon-kter commented 8 months ago

and again https://monitor.f-droid.org/builds/log/io.rosenpin.screenshotsharer/50#site-footer

licaon-kter commented 8 months ago

and diff log: scr50.log

@rosenpin how are you building these APKs exactly?

rosenpin commented 8 months ago

and diff log: scr50.log

@rosenpin how are you building these APKs exactly?

Android studio > build > generate signed apk > release

rosenpin commented 8 months ago

I forgot to update the kotlin build lib so it might be it

licaon-kter commented 8 months ago

ping us to test the next release then

rosenpin commented 7 months ago

updated the build tools and created a new release

licaon-kter commented 7 months ago

3.9 only difference is

│ │ │ │ │   --- screenshot-sharer_3.9/smali_classes2/io/rosenpin/screenshotsharer/DaggerScreenshotSharer_HiltComponents_SingletonC$SingletonCImpl.smali
│ │ │ │ ├── +++ io.rosenpin.screenshotsharer_70/smali_classes2/io/rosenpin/screenshotsharer/DaggerScreenshotSharer_HiltComponents_SingletonC$SingletonCImpl.smali
│ │ │ │ │ @@ -118,15 +118,15 @@
│ │ │ │ │  .method public injectScreenshotSharer(Lio/rosenpin/screenshotsharer/ScreenshotSharer;)V
│ │ │ │ │      .locals 0
│ │ │ │ │      .annotation system Ldalvik/annotation/MethodParameters;
│ │ │ │ │          accessFlags = {
│ │ │ │ │              0x0
│ │ │ │ │          }
│ │ │ │ │          names = {
│ │ │ │ │ -            "screenshotSharer"
│ │ │ │ │ +            "arg0"
│ │ │ │ │          }
│ │ │ │ │      .end annotation
rosenpin commented 7 months ago

Honestly I have no idea what this is about.
The code is compiled from the github source code, if there's any problem with that then unfortunately it seems like something I can't solve, it's either an issue on F-droid's end or with one of the standard libraries.
If you find more information about the reason for this please let me know and I'll try to fix it.