rosepearson / GeoFabrics

A package for generating hydrologically conditioned DEMs and roughness maps from LiDAR and other infrastructure data. Check the wiki for install and usage instructions, and documentation at https://rosepearson.github.io/GeoFabrics/
GNU General Public License v3.0
27 stars 11 forks source link

227 ensure passing tests form refactor rawdem #228

Closed rosepearson closed 9 months ago

rosepearson commented 9 months ago

@jennan I've created a PR into your refactor branch to fix the breaking tests. Plesae note I am working a few days during the holidays when it is raiing in the mtns so I can go tramping the 3-4. Please do not feel to have to do anything until you're back at work after your RESTful restful holidays :).

DESCRIPTION OF PR:

jennan commented 9 months ago

@rosepearson Thank you Rose for looking into this :-). I didn't realise that changing the masking logic from not (something and something_else) to (not something) or (not something else) would cause issues with NaNs. I have used this change in multiple places, I will double check this.