search

rosjava / android_core

Android libraries for rosjava
145 stars 166 forks source link

NodeMainExecutorService leaks RosActivity through NodeMainExecutorServiceListener #254

Closed stratomda closed 7 years ago

stratomda commented 7 years ago

When a RosActivity is destroyed, and the main application is still running, the NodeMainExecutorService contains a reference to the RosActivity preventing it from gc. The fix is to add the ability to remove the NodeMainExecutorServiceListener created in the RosActivity from the NodeMainExecutorService ListenerGroup. This requires ListenerGroup to contain a method for removing a listener (bug filed in rosjava/rosjava_core https://github.com/rosjava/rosjava_core/issues/233).

jubeira commented 7 years ago

This was fixed for Indigo but not for Kinetic yet, am I right?

stratomda commented 7 years ago

That seems to be correct.

adamantivm commented 7 years ago

That was my fault, I screwed something up when I tried to do the update - I got the 0.3.2 to release but failed to push upstream from my local copy. It should be fixed now, but I'd appreciate a second pair of eyes.

jubeira commented 7 years ago

LGTM; I think this issue can be closed now.

stratomda commented 7 years ago

@adamantivm is this issue still open or was it merged into 0.3.3?

adamantivm commented 7 years ago

It's merged and published!