Adds capability to remember recent hosts.

rosjava / android_core

Android libraries for rosjava

145 stars 166 forks source link

Adds capability to remember recent hosts. #263

Closed stratomda closed 7 years ago

stratomda commented 7 years ago

Adds capability to remember recent hosts. When entering the Master URI a list of recent Master URIs is presented. This implements the Remember recent hosts task in rosjava/android_core#257.

[X] Remember recent hosts (useful when changing masters)

jubeira commented 7 years ago

The code is looking good @stratomda ! Apart from the nits that @adamantivm pointed out, I would leave a space after statements like for, if, etc. so as to match the general coding style of rosjava. In summary:

Braces in the same line of statements, with one space after the end of the control statement.
Parenthesis with one space after the control statements.

I haven't tried the changes in an app yet, I will do soon when I have some time. Thanks again for your work!

stratomda commented 7 years ago

Sorry about those formatting issues. I'll make sure to follow those on the next commit!

stratomda commented 7 years ago

Lets create an issue and we can hopefully add an option to the MasterChooserSettings to clear recent Master URIs. Does that sound like a plan? Otherwise in advanced options I could add an option to remove them as well.

adamantivm commented 7 years ago

@stratomda I would be perfectly OK with your proposal of an issue. Would you mind going ahead and creating it? Or alternatively updating the issue you and @jubeira have been using to track desired updates to the Master Chooser. Either would be fine.