rossant / ipycache

Defines a %%cache cell magic in the IPython notebook to cache results of long-lasting computations in a persistent pickle file
BSD 3-Clause "New" or "Revised" License
138 stars 35 forks source link

Fix GitHub Actions setup and test config #55

Closed mbrukman closed 2 years ago

mbrukman commented 2 years ago

Per the most recent GitHub Actions run, fix the setup and test commands:

The list of available Python versions shows Python 3.5 and later are provided.

Minor changes:

Closes https://github.com/rossant/ipycache/issues/52

rossant commented 2 years ago

Perhaps old versions of Python like 2.7, 3.5, 3.6, may be dropped?

mbrukman commented 2 years ago

Perhaps old versions of Python like 2.7, 3.5, 3.6, may be dropped?

Done.

mbrukman commented 2 years ago

@rossant — since we've removed testing with Python 2.7, should we also remove special-casing for Python 2 (see below), or should we bring back the tests for Python 2.7 to keep backwards-compatibility? I know Python 2.x was EOL as of Jan 2020, but maybe some folks somewhere are still depending on using it (somehow)?

https://github.com/rossant/ipycache/blob/ebefe10d69d2e519060b4767c5778ab808fb488e/ipycache.py#L28-L52

rossant commented 2 years ago

I think it's fine to drop Python 2.x support. Maybe add a tag before doing it to be on the safe side..