search

rotki / rotki

A portfolio tracking, analytics, accounting and management application that protects your privacy
https://rotki.com
GNU Affero General Public License v3.0
2.78k stars 508 forks source link

Add support for Makerdao vaults managed by InstaDapp #1565

Open froid1911 opened 3 years ago

froid1911 commented 3 years ago

Abstract

InstaDapp is a smart wallet for DeFi stuff.

Motivation

A lot of users use the features of InstaDapp and currently this doenst show up on rotki. zerion.io provides a good example how instadapp could show up on rotki.

thibauld commented 3 years ago

This is partially true. Instadapp "kinda works" with Rotki: you need to register you instadapp address as a Rotki account: image

I am only using instadapp to interact with my MakerDAO vaults and it is true that those vaults are not detected by Rotki. I only see the collateral deposited in those vaults in the "Defi overview" screen as "Wrapped Ether" in the "multi-collateral dai" tile. My vaults do not show up in deposits or liabilities (they should).

LefterisJP commented 3 years ago

Can you provide addresses in a DM or something and things that don't show up for instadapp? I would like to investigate.

LefterisJP commented 2 years ago

Will turn this issue into the specific question of properly detecting makerdao vaults in instadapp.

LefterisJP commented 1 year ago

Not sure if any more work will need to be done here since if instadapp just uses DSproxies then this may be already solved by the changes we made to detecting all proxy tokens.

LefterisJP commented 1 year ago

Can either @thibauld or @froid1911 provide an example address to test with to see if this is done yet or not?