rotki / rotki

A portfolio tracking, analytics, accounting and management application that protects your privacy
https://rotki.com
GNU Affero General Public License v3.0
2.8k stars 515 forks source link

Sorting AdEx events #2279

Closed vnavascues closed 3 years ago

vnavascues commented 3 years ago

Given the same timestamp, the order of the events should be: Claim -> Withdraw -> Deposit. The default order in the frontend is: Deposit -> Withdraw -> Claim.

                {
                    "event_type": "claim",
                    "identity_address": "",
                    "pool_id": "0x2ce0c96383fb229d9776f33846e983a956a7d95844fac57b180ed0071d93bb28",
                    "pool_name": "Tom",
                    "timestamp": 1607453760,
                    "token": "ADX",
                    "tx_hash": "",
                    "value": {
                        "amount": "5056.894263641728544592",
                        "usd_value": "1440.96202042471054878149040"
                    }
                },
                {
                    "bond_id": "0x540cab9883923c01e657d5da4ca5674b6e4626b4a148224635495502d674c7c5",
                    "event_type": "withdraw",
                    "identity_address": "",
                    "pool_id": "",
                    "pool_name": "Tom",
                    "timestamp": 1607453760,
                    "tx_hash": "",
                    "value": {
                        "amount": "100000",
                        "usd_value": "28495.00000"
                    }
                },
                {
                    "bond_id": "0x16bb43690fe3764b15a2eb8d5e94e1ac13d6ef38e6c6f9d9f9c745eaff92d427",
                    "event_type": "deposit",
                    "identity_address": "",
                    "pool_id": "0x2ce0c96383fb229d9776f33846e983a956a7d95844fac57b180ed0071d93bb28",
                    "pool_name": "Tom",
                    "timestamp": 1607453760,
                    "tx_hash": "",
                    "value": {
                        "amount": "105056.894263641728544592",
                        "usd_value": "29935.96202042471054878149040"
                    }
                },
vnavascues commented 3 years ago

@kelsos this is the front-end issue regarding the order of the AdEx events.

LefterisJP commented 3 years ago

@kelsos we keep moving this around. This is a premium components issue right? Should be trivial or is my understanding wrong? Just schedule it bundled with the next premium components update.

kelsos commented 3 years ago

I am not sure how trivial that would be. I need to implement some custom sorting mechanism but I am not sure how that would work

LefterisJP commented 3 years ago

Removing and closing, since if it's not trivial I don't think we need it at this point. May re-open if it somehow changes.

I see no point in moving it around anymore.