search

roughike / flutter_facebook_login

A Flutter plugin for allowing users to authenticate with native Android & iOS Facebook login SDKs.
BSD 2-Clause "Simplified" License
404 stars 332 forks source link

Mark package as deprecated in README.md #269

Open brianbhsu opened 4 years ago

brianbhsu commented 4 years ago

I think it's a good idea to mark this package as deprecated in the README, so people don't have to go digging through the issues, Facebook SDK documentation, and Apple documentation to find out that they should no longer use this package for submitting new apps to the App Store.

The main reason being as of Facebook SDK version 6.0.0, the "FBSDKLoginBehavior Login flows no longer support logging in through the native application." Which means you will have to use the browser login flow.

Hopefully this saves everyone some googling.

P.S. If you want include a Facebook login button, you'll have to include an Apple login button as well :)

sjapps commented 4 years ago

Should this just be re-written with WKWebview that just returns the token? Which is what it does today anyways?

quentinleguennec commented 4 years ago

@brianbhsu Good to know about the Apple button, thanks! For people curious about it here is the rule from Apple:

4.8 Sign in with Apple Apps that use a third-party or social login service (such as Facebook Login, Google Sign-In, Sign in with Twitter, Sign In with LinkedIn, Login with Amazon, or WeChat Login) to set up or authenticate the user’s primary account with the app must also offer Sign in with Apple as an equivalent option. A user’s primary account is the account they establish with your app for the purposes of identifying themselves, signing in, and accessing your features and associated services.

There are some exceptions but most apps will fall under this rule.

brianbhsu commented 4 years ago

@sjapps Sorry for the late response. I'm not an expert with the Facebook SDK, but I think that would be one possible solution with WKWebView.

Imo the best route for this library would be to upgrade to the latest Facebook SDK version and implement it the standard way that it is currently being used in iOS and Android apps. Whether that's WKWebView or another option.

sjapps commented 4 years ago

@brianbhsu Do you know how old is the SDK version? I've been doing iOS for a while so I can help with the upgrade. Not a clue about Android.

brianbhsu commented 4 years ago

@sjapps Pretty sure it's 5.5.0. https://github.com/roughike/flutter_facebook_login/blob/dcb28f06a76f3ddc3a18a2e88b6f7dfa88b4ba4d/ios/flutter_facebook_login.podspec#L18

And the most recent Facebook SDK version is 7.0.0. https://github.com/facebook/facebook-ios-sdk/blob/master/CHANGELOG.md