rougier / nano-emacs

GNU Emacs / N Λ N O - Emacs made simple
GNU General Public License v3.0
2.52k stars 194 forks source link

Require disp-table before attempting to access standard-display-table #67

Closed ndw closed 3 years ago

ndw commented 3 years ago

This PR fixes #28. It was suggested in email following my Emacs bug report.

rougier commented 3 years ago

Sorry for the delay. Could you rebase your PR?

ndw commented 3 years ago

Done

rougier commented 3 years ago

Thanks. The diff on GitHub still indicates large change Did you push your rebase?

ndw commented 3 years ago

Near as I can tell, yes:

$ git diff upstream/master
diff --git a/nano-layout.el b/nano-layout.el
index 47fe9a3..1e53ef4 100644
--- a/nano-layout.el
+++ b/nano-layout.el
@@ -16,6 +16,8 @@
 ;; along with this program. If not, see <http://www.gnu.org/licenses/>.
 ;; ---------------------------------------------------------------------

+(require 'disp-table)
+
 (setq default-frame-alist
       (append (list
               '(font . "Roboto Mono:style=Light:size=14")

nano-emacs on  fix28 [$]
$ git push
Everything up-to-date
rougier commented 3 years ago

@brongulus Separate issue for the menu-bar would be nice yes. @ndw I4ve no idea why GitHub reports such large change to be made. Could you try a new PR just to be sure?

ndw commented 3 years ago

Right. I don't know either. I'll make new PRs today.

ndw commented 3 years ago

Superceded by #72.