search

rougier / nano-theme

GNU Emacs / N Λ N O Theme
GNU General Public License v3.0
358 stars 35 forks source link

New frame background doesn't follow the currently using theme. #14

Closed chuxubank closed 2 years ago

chuxubank commented 2 years ago

When using make-frame-command within nano-dark-theme, the new frame's background is light.

pmatos commented 2 years ago

True - I have just noticed this with mu4e. If I start to compose a new email on a new frame. When the frame opens, it's in light mode. No idea why tbh. @rougier any ideas?

rougier commented 2 years ago

Yes, something wrong and this might be related to #12 as well. As a temporary workaround, there is a nano-make-frame command where you can specify the theme. I'm working on it but most probably, I forgot to set something. The theme (dark/light) is supposed to be chosen automatically from the frame background-mode but for newly created frame, there should be some default value somewhere that I need to take into account.

pmatos commented 2 years ago

Yes, something wrong and this might be related to #12 as well. As a temporary workaround, there is a nano-make-frame command where you can specify the theme. I'm working on it but most probably, I forgot to set something. The theme (dark/light) is supposed to be chosen automatically from the frame background-mode but for newly created frame, there should be some default value somewhere that I need to take into account.

Thanks for looking into this.

rougier commented 2 years ago

I've just pushed a tentative fix

chuxubank commented 2 years ago

Confirm fixed! Thx!