Can't insert signature in external compose window if opened from inline compose window

[rcubetrac]

Reported by fup on 16 Sep 2014 14:19 UTC as Trac ticket #1490074

If I open the external compose window from the "inline" compose window by clicking on the icon top-right, I can't manually insert my signature because the button is disabled.

Only after reloading the page the button is activated.

This problem doesn't exist if using an external window for composing is set in my preferences.

The activation of the button happens in change_identity() (app.js:3862ff), which is apprently not being called (properly) when opening the window manually.

Simply specifying the second parameter as true in app.js:3166 doesn't work. A fix is to insert the following into init_messageform() (app.js:3117ff):

// enable manual signature insert
if (this.env.signatures) {
  this.enable_command('insert-sig', true);
  this.env.compose_commands.push('insert-sig')
}

As far as I can see that might call the same functions twice during the same request, which is not desirable. But I didn't find a better solution.

Migrated-From: http://trac.roundcube.net/ticket/1490074

[rcubetrac]

Comment by @alecpl on 16 Sep 2014 17:19 UTC

Confirmed.

[rcubetrac]

Milestone changed by @alecpl on 16 Sep 2014 17:19 UTC

later => 1.0.3

[rcubetrac]

Comment by @thomascube on 26 Sep 2014 22:09 UTC

The change_identity() call is aborted if opened in extwin. This was added in https://github.com/roundcube/roundcubemail/commit/3b944edb02.

Now fixed in git master with commit e0496fc01d.

[rcubetrac]

Comment by @thomascube on 26 Sep 2014 22:14 UTC

Backported to release-1.0 in fef904c6b1.

[rcubetrac]

Status changed by @thomascube on 26 Sep 2014 22:14 UTC

new => closed