search

routerkeygen / routerkeygenAndroid

Router Keygen generate default WPA/WEP keys for several routers.
460 stars 169 forks source link

F-Droid submission #10

Closed pejakm closed 10 years ago

pejakm commented 10 years ago

Hi. Did the author perhaps thought of submitting this app to F-Droid repo?

ruiaraujo commented 10 years ago

I did. Last time, I checked they hated the ads.

pejakm commented 10 years ago

Ah, now I see the submission topic: https://f-droid.org/forums/topic/router-keygen/

It's almost a year old, could you please try once again? :)

ruiaraujo commented 10 years ago

That wasn't me. ;)

Can you do it? I don't really care about F droid. Otherwise I will do it a day when I am really bored! :P

pejakm commented 10 years ago

Oh, well, I can, but I thought it would be better author to submit it. :D Is there any things I should mention in a submission? Like "AntiFeatures:Tracking" stated in submission thread I posted above?

ruiaraujo commented 10 years ago

That "Tracking" thing isn't true anymore. Crash reports now require action from the user to be sent.

I have no idea how to submit it. Feel free to comment on this issue to ask for question. Have fun and good luck.

pejakm commented 10 years ago

Okay, I'll post updates, if anything changes. Thanks for your help.

pejakm commented 10 years ago

Well, here's a post from moderator:

I can move it to the queue, but for what? Had a quick look and it includes playservices. Did you try to strip them?

They can't build an app if it relies on proprietary parts, like Google Play Sevices. Is it possible to build Router Keygen without it?

ruiaraujo commented 10 years ago

I can have a version with Play Services, but am I required to strip the ads? That's also proprietary. If so, just forget it.

On 23 September 2014 17:35, Mladen notifications@github.com wrote:

Well, here's a post from moderator:

I can move it to the queue, but for what? Had a quick look and it includes playservices. Did you try to strip them?

They can't build an app if it relies on proprietary parts, like Google Play Sevices. Is it possible to build Router Keygen without it?

— Reply to this email directly or view it on GitHub https://github.com/routerkeygen/routerkeygenAndroid/issues/10#issuecomment-56539220 .

pejakm commented 10 years ago

Uhm, no, I didn't say that, I just wanna know if playservices are required for the app to build successfully. :) I have it running on my phone, and I don't have any Google stuff installed, so I presume playservices aren't hard requirement?

ruiaraujo commented 10 years ago

Nope they aren't. Well they are because of the ads but I can work around that. It does give me some work so you have to be sure that they have no problem with ads before you convince me to that. ;-)

On 23 September 2014 17:45, Mladen notifications@github.com wrote:

Uhm, no, I didn't say that, I just wanna know if playservices are required for the app to build successfully. :) I have it running on my phone, and I don't have any Google stuff installed, so I presume playservices aren't hard requirement?

— Reply to this email directly or view it on GitHub https://github.com/routerkeygen/routerkeygenAndroid/issues/10#issuecomment-56540905 .

pejakm commented 10 years ago

Okay, great, thank you for your explanation. :) I'll see what will mods from f-droid says.

Kind regards! :)

pejakm commented 10 years ago

Okay, here's a response from a moderator:

Ads itself are not a problem, we consider them an antifeature which gets marked, but which _doesn’t prevent inclusion_. However, if the app contains/requires non-free software or even binaries to show them, we cannot build it.

ruiaraujo commented 10 years ago

Which is total bullshit. Since most ads libraries are proprietary. See what I meant?

On 23 September 2014 19:09, Mladen notifications@github.com wrote:

Okay, here's a response from a moderator:

Ads itself are not a problem, we consider them an antifeature which gets marked, but which doesn’t prevent inclusion. However, if the app contains/requires non-free software or even binaries to show them, we cannot build it.

— Reply to this email directly or view it on GitHub https://github.com/routerkeygen/routerkeygenAndroid/issues/10#issuecomment-56554635 .