rozniak / xfce-winxp-tc

Windows XP stuff for XFCE
Other
1.14k stars 37 forks source link

Clock always displays in 24-hour format #154

Open rozniak opened 2 years ago

rozniak commented 2 years ago

Guess I didn't think of this, the clock currently just displays the time in 24-hour format. This is hard-coded because it is what I am used to but it needs to be changed to match the user's locale: https://github.com/rozniak/xfce-winxp-tc/blob/master/shell/systray/src/clock.c#L147

Looks like we need to perhaps use X? https://docs.gtk.org/glib/method.DateTime.format.html

rozniak commented 2 years ago

Removing good-first-issue.

Seems like %X includes seconds, which is not what we want. After having a search around considering this seems like it would be a common-ish problem, the most rational solution seems to be to include the time format as a translated string.

This is a bit aggy because the burden of the work is on this project rather than a system library but oh well not the end of the world. This is something we can add to the shllang library.