rozniak / xfce-winxp-tc

Windows XP stuff for XFCE
Other
1.13k stars 37 forks source link

Conflict for notepad with wine #202

Closed SelfRef closed 1 year ago

SelfRef commented 1 year ago

The default notepad binary name at /usr/bin/notepad has name collision with notepad from wine. At least on Arch Linux, not sure about Debian. Probably the only option would be to change the name to be unique because it can be a common case to have wine already installed.

rozniak commented 1 year ago

Sugar, wine on Arch comes with a notepad? On Debian it doesn't, you just get wine and some of the utils (regedit).

Kind of a pickle, because I named it notepad so that you could launch it identical to Windows :weary:

SelfRef commented 1 year ago

Yeah. I was a little surprised when looked in Debian package and I didn't see a notepad binary in tree. Is it probably somewhere else in separate package? Or not at all? There is a full files tree for Arch.

Kind of a pickle, because I named it notepad so that you could launch it identical to Windows 😩

Hmm, at least notepad.exe is still free to use. Not canonical for Unix but still available option.

Lili1228 commented 1 year ago

Every Wine comes with Notepad, it's just that Arch has a glorified symlink to wine notepad in /usr/bin

rozniak commented 1 year ago

Mmmm I'm really not keen on notepad.exe... if anything the WINE one should be called that, no? :sweat_smile:

Not sure atm

SelfRef commented 1 year ago

For compatibility purposes I've changed to wintc-notepad in AUR version. I wonder if other distros also have this symlink to notepad. If not, then it's only Arch-related.

rozniak commented 1 year ago

I think as part of the porting process need to check if this symlink for notepad exists when WINE is installed on the target distro. For the distros that have this sadly there is no choice but to use wintc-notepad really is there?

If so, I would probably suggest:

rozniak commented 1 year ago

Have resolved this, for archpkg the output executable will be wintc-notepad. Will test this on a case-by-case basis in future when porting to check whether notepad will clash, and not rename the target if so.

Thanks again for your testing and patience @SelfRef !

SelfRef commented 1 year ago

Thanks again for the fix!

The solution with checking if wine symlink is in the filesystem wouldn't work because if user would install xfce-winxp-tc and then wine package then wine installation would fail. Conditional name is probably the best solution as in your fix.