search

rpgmaker / NetJSON

Faster than Any Binary? Benchmark: http://theburningmonk.com/2014/08/json-serializers-benchmarks-updated-2/
MIT License
231 stars 29 forks source link

IntUtility not working #158

Closed imacks closed 7 years ago

imacks commented 7 years ago

I am only getting 0-9 correct when calling IntUtility.itoa

From 10-9999 only the first digit survives. Any number beyond that turns into an empty string :(

rpgmaker commented 7 years ago

Hi,

Just curious, why are you calling the method directly?. There is a different method call IntToStr if you are just using integer conversion from the library only. Most things are not used from IntUtility.

Thanks,

imacks commented 7 years ago

I am just wondering if this is on the fix todo list.

rpgmaker commented 7 years ago

I will clean it up during the performance update that I have planned.

Thanks,

rpgmaker commented 7 years ago

Feel free to help me resolve it by creating a pull request.

rpgmaker commented 7 years ago

Since I recently marked most of the internally used classes as internal. I don't know if this is still valid. The intention was not to make a int utility class available. I am going to close this for now. If this is still important to you, i can fix the bug if you are just utilizing the piece of code without using NetJSON directly.

Thanks,