search

rpherbig / dr-scripts

A series of Lich 5 (https://github.com/elanthia-online/lich-5) scripts for use with DragonRealms (http://www.play.net/dr/). Donations are welcome (http://www.paypal.me/rcuhljr)!
GNU General Public License v2.0
54 stars 178 forks source link

[script] [truffenyi-commune-quest] make truffenyi script more feature rich #6926

Closed vtcifer closed 1 month ago

vtcifer commented 1 month ago

Handle solving the altar puzzle Slightly better vial handling Handle the shrine/ox puzzle

Still will not find shrine for you

vtcifer commented 1 month ago

GTG even with rubocop warnings (most are indent issue which are present for better code collapse)

vtcifer commented 1 month ago

GTG even with rubocop warnings (most are indent issue which are present for better code collapse)

MahtraDR commented 1 month ago

Can uuu you please do the rubocop autocorrects or propose a change to the rubocop rules? I accept the indentation folding idea, but rubocop keeps me sane too.

vtcifer commented 1 month ago

IMO rubocop makes a good sniff test for happy flows - it catches a lot of 'oops' in those. But for unhappy flows it should be 'someone 4-eyes this', not as the final arbiter. If the committer can articulate a good justification for the ignoring it should be OK.

Just my .02

*ETA: That said, I'll take a pass at inline rubocop directives explaining this in code.

vtcifer commented 1 month ago

Given how messy this PR is with the commits, just ping me on discord if you're OK with how I've handled rubocop and I'll do another branch with a cleaner commit history for merging.

MahtraDR commented 1 month ago

This works for me. Thanks!