rpherbig / dr-scripts

A series of Lich 5 (https://github.com/elanthia-online/lich-5) scripts for use with DragonRealms (http://www.play.net/dr/). Donations are welcome (http://www.paypal.me/rcuhljr)!
GNU General Public License v2.0
54 stars 178 forks source link

[script] [combat-trainer] Option for Bard cyclic to segue to on combat end instead of releasing #6937

Closed hat071af closed 3 weeks ago

hat071af commented 1 month ago

Adds an option for Bards to segue to a chosen cyclic spell when combat ends instead of releasing their cyclic. If the segue fails it will still release the original cyclic if it's not on the cyclic_no_release list.

These are the settings needed in your character yaml:

# Set a cyclic spell to segue to instead of releasing a cyclic when combat-trainer ends. 
# Bard only setting. Must know how to segue. 
# Strongly recommended to use a justice safe spell. Works best when using a spell from cyclic_no_release: 
# Use the cyclic spell abbrevation. E.g. botf. The segue parser doesn't like full spell names.
segue_spell_on_stop: botf
segue_prep_on_stop: 25
MahtraDR commented 3 weeks ago

This looks really neat. Sorry I missed it earlier. It does need those two settings in base-yaml.yaml blanked out though.

hat071af commented 3 weeks ago

This looks really neat. Sorry I missed it earlier. It does need those two settings in base-yaml.yaml blanked out though.

Hrm. Can you elaborate/clarify? I tested it without them existing in either base.yaml and my character-setup.yaml and it just skips the 3 lines I added. I.e. segue_spell_on_stop doesn't exist so the if statement if DRStats.guild == "Bard" && @settings.segue_spell_on_stop returns false and it moves on to the usual release cyclic check.

I can add them to base.yaml if needed, though.

MahtraDR commented 3 weeks ago

This looks really neat. Sorry I missed it earlier. It does need those two settings in base-yaml.yaml blanked out though.

Hrm. Can you elaborate/clarify? I tested it without them existing in either base.yaml and my character-setup.yaml and it just skips the 3 lines I added. I.e. segue_spell_on_stop doesn't exist so the if statement if DRStats.guild == "Bard" && @settings.segue_spell_on_stop returns false and it moves on to the usual release cyclic check.

I can add them to base.yaml if needed, though.

Yes please add them. Weird, without them defined at all it should error, ah well. Good practices chug one! :)

MahtraDR commented 3 weeks ago

Thanks!