Closed syokensyo closed 1 year ago
@syokensyo Any chance you could add an end-to-end test, building a package with a symbolic link and installing it / and checking the file entries in the header?
The two places to touch:
@syokensyo Any chance you could add an end-to-end test, building a package with a symbolic link and installing it / and checking the file entries in the header?
The two places to touch:
- https://github.com/rpm-rs/rpm/blob/master/tests/compat.rs#L36 - Add a symlink to the built package
- https://github.com/rpm-rs/rpm/blob/master/src/tests.rs#L50 - Add a symlinks and update the code that checks the file entries in the header
Sure, will work on this.
To use existing with_file
api, add an empty file in test_assets for the symbolic file to create.
@syokensyo See CI failures
Forgot to revert the temp file permission changes for existing test case to pass on my local machine, reverted.
Thanks for the contribution! I can squash the typo later, unless you want to take a pass at cleaning up the Files APIs? :D
PR Content Desc
FileMode::file_type
is public, so it is better to make the constREGULAR_FILE_TYPE
DIR_FILE_TYPE
SYMBOLIC_LINK_FILE_TYPE
public also to ease usage.📜 Checklist
--all-features
enabled