rpm-rs / rpm

Other
47 stars 26 forks source link

add symbolic link file type support #168

Closed syokensyo closed 1 year ago

syokensyo commented 1 year ago

PR Content Desc

📜 Checklist

dralley commented 1 year ago

@syokensyo Any chance you could add an end-to-end test, building a package with a symbolic link and installing it / and checking the file entries in the header?

The two places to touch:

syokensyo commented 1 year ago

@syokensyo Any chance you could add an end-to-end test, building a package with a symbolic link and installing it / and checking the file entries in the header?

The two places to touch:

Sure, will work on this.

syokensyo commented 1 year ago

To use existing with_file api, add an empty file in test_assets for the symbolic file to create.

dralley commented 1 year ago

@syokensyo See CI failures

syokensyo commented 1 year ago

Forgot to revert the temp file permission changes for existing test case to pass on my local machine, reverted.

dralley commented 1 year ago

Thanks for the contribution! I can squash the typo later, unless you want to take a pass at cleaning up the Files APIs? :D