search

rpm-rs / rpm

Other
47 stars 26 forks source link

WIP: utilize binrw serialization/deserialization for Lead #230

Closed marxin closed 5 months ago

marxin commented 5 months ago

Hey. Recently, I've been playing with a great binary serialization and deserialization library and thought it would be cool to use it for the RPM project. What are the thoughts of the community about it?

I made a simple demonstration for the Lead struct, but I'm still struggling when it comes to more complex data like IndexData (where the content is split between The Index Entry and the actual data). I'm still working on that (https://github.com/jam1garner/binrw/discussions/267).

dralley commented 5 months ago

To be completely honest I find the macros less straightforwards to read than the current code, which is pretty clean and not particularly complex.

marxin commented 5 months ago

To be completely honest I find the macros less straightforwards to read than the current code, which is pretty clean and not particularly complex.

Sure, understood.