rpm-rs / rpm

Other
47 stars 26 forks source link

Add feature flags for compression algorithms #241

Closed famfo closed 1 month ago

famfo commented 1 month ago

This pull request adds a feature flag for every compression algorithm. All compression algorithms are all enabled by default, but can be disabled in case they are not used to reduce the amount of dependencies.

Please note: I couldn't run all the tests because some containers are not found in the registry I am using.

famfo commented 1 month ago

What should I do about the failing tests on no-default-features? I could disable the tests which need a specific compression for now.

dralley commented 1 month ago

What should I do about the failing tests on no-default-features? I could disable the tests which need a specific compression for now.

Flag the test on the availability of the compression for now I suppose.

Could you explain your motivation for the PR - is it just reducing dependencies in a use case that doesn't require them? (That's perfectly fine, I'm just curious)

famfo commented 1 month ago

Mostly a use case that doesn't require anything else than zstd and we'd like to reduce the amount of C code we link against.

dralley commented 1 month ago

Do you have more changes planned? If not I can do a new release, otherwise I can wait.

famfo commented 1 month ago

Decompressing content from archives would still be nice but implementing that would probably still take a few days.