search

rpm-software-management / yum

[DEPRECATED] YUM package manager
GNU General Public License v2.0
127 stars 87 forks source link

yum-cron: reintroduce days_of_week parameter #40

Closed whereismyjetpack closed 4 years ago

whereismyjetpack commented 7 years ago

In previous versions of yum_cron we had available to us the days_of_week parameter. This patch reintroduces that behavior, and adds the default days_of_week setting in the sample configuration files.

whereismyjetpack commented 7 years ago

Thanks for the review. I've pushed up the required changes, please let me know if you need anything else.

whereismyjetpack commented 7 years ago

Should be all fixed up now. Thanks!

whereismyjetpack commented 6 years ago

I've committed the changes to docs. Thanks!

dmnks commented 6 years ago

Actually, you make a good point regarding the el6 version, which I didn't realize initially. The earlier bash version of yum-cron in el6 used date +%w which indeed returns 0 for Sunday. After all, in crontab, day of week also has 0 for Sunday.

That said, I would rather lean towards making yum-cron compatible with both the el6 version and crontab. Could you maybe update the patch accordingly? One way is replacing weekday() with isoweekday() % 7 which should give you the original range 0..6 where 0 is Sunday.

Thank you again!

coreypenford commented 5 years ago

@whereismyjetpack Is there a possibility of this getting picked up again and merged? If not I may open my own PR with your changes + @dmnks's requested ones. Pretty basic functionality that would be nice to have

dmnks commented 4 years ago

Thank you for the PR. However, please note that this project has been deprecated and is no longer maintained upstream. Please consider migrating to DNF which is the successor of YUM. That said, I’ll close this PR now.