rpm-software-management / yum

[DEPRECATED] YUM package manager
GNU General Public License v2.0
127 stars 87 forks source link

Fix #95 #96

Closed dnagl closed 5 years ago

dnagl commented 5 years ago

This commit should fix issue #95

dmnks commented 5 years ago

Hi David, Are you sure this was the culprit? Doesn't /path/{A,B,C} expand to /path/A, /path/B and /path/C anyway?

dnagl commented 5 years ago

I know, I tried the command manually on the commandline and there this worked fine. I tried this on several machines with different OS and different environments. But I was not able to build this. The command always creaed this folder build/SOURCES,SRPMS,RPMS and so the following steps which are trying to work in the generated directories do not work.

dmnks commented 5 years ago

OK, it seems brace expansions are not POSIX-compliant (although bash and most other shells do support them).

I'm fine with the patch then. Before I merge it, though, please also do the same correction under the clean: target where we do rm -f $(BUILDDIR)/{SOURCE,SRPMS,RPMS}/*.

dnagl commented 5 years ago

@dmnks I added the changes in the clean: target.

dmnks commented 5 years ago

Merged, thanks!