rpoleski / MulensModel

Microlensing Modelling package
https://rpoleski.github.io/MulensModel/
Other
57 stars 15 forks source link

Forced SkyCoord input to be equatorial, issue #70 #119

Closed rapoliveira closed 10 months ago

rapoliveira commented 10 months ago

The input for the Coordinates class is now checked in the function _validate_input() to forbid the Galactic frame. Only 'icrs', 'fk4', 'fk5' frames are allowed, as well as instances of their classes.

For this reason, any transformation to different frames need to be done transforming to SkyCoord first, e.g.: gal_l = SkyCoord(self).galactic.l ecl_l = SkyCoord(self).transform_to(GeocentricTrueEcliptic).lon

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (dff8bc5) 83.53% compared to head (50e9b4e) 83.59%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #119 +/- ## ========================================== + Coverage 83.53% 83.59% +0.05% ========================================== Files 52 52 Lines 8286 8313 +27 ========================================== + Hits 6922 6949 +27 Misses 1364 1364 ``` | [Flag](https://app.codecov.io/gh/rpoleski/MulensModel/pull/119/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Radek+Poleski) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/rpoleski/MulensModel/pull/119/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Radek+Poleski) | `83.59% <100.00%> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Radek+Poleski#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.